From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Wed, 25 Feb 2015 14:59:02 +0000 (+0300)
Subject: common/board_f: implement type casting for gd structure
X-Git-Tag: v2025.01-rc5-pxa1908~13647
X-Git-Url: http://git.dujemihanovic.xyz/posts?a=commitdiff_plain;h=7bf9f20d0246e0985c5c06bb56b3e9ce9300fcde;p=u-boot.git

common/board_f: implement type casting for gd structure

In case of global data structure defined as "register volatile" compiler
throws an warning about incorrect type used:
 --->8---
 common/board_f.c: In function "board_init_f_r":
 common/board_f.c:1073:2: warning: passing argument 1 of "&board_init_r
 +(sizetype)gd->reloc_off" discards "volatile" qualifier from pointer
 target type [enabled by default]
  (board_init_r + gd->reloc_off)(gd, gd->relocaddr);
  ^
 common/board_f.c:1073:2: note: expected "struct gd_t *" but argument is
 of type "volatile struct gd_t *"
 --->8---

An obvious fix is manual casting to "gd_t *".

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@ti.com>
Acked-by: Simon Glass <sjg@chromium.org>
---

diff --git a/common/board_f.c b/common/board_f.c
index 1989c8193d..fc3e7ddd10 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -1062,7 +1062,7 @@ void board_init_f_r(void)
 	 * Transfer execution from Flash to RAM by calculating the address
 	 * of the in-RAM copy of board_init_r() and calling it
 	 */
-	(board_init_r + gd->reloc_off)(gd, gd->relocaddr);
+	(board_init_r + gd->reloc_off)((gd_t *)gd, gd->relocaddr);
 
 	/* NOTREACHED - board_init_r() does not return */
 	hang();