From: Rabin Vincent <rabin@rab.in>
Date: Wed, 29 Oct 2014 22:21:41 +0000 (+0100)
Subject: hush: make run_command() return an error on parsing failure
X-Git-Tag: v2025.01-rc5-pxa1908~14347
X-Git-Url: http://git.dujemihanovic.xyz/posts?a=commitdiff_plain;h=2302b3ab85843c9a8dbb3a924030659d87a23349;p=u-boot.git

hush: make run_command() return an error on parsing failure

run_command() returns success even if the command had a syntax error;
correct this behaviour.

Signed-off-by: Rabin Vincent <rabin@rab.in>
Acked-by: Simon Glass <sjg@chromium.org)
---

diff --git a/common/cli_hush.c b/common/cli_hush.c
index a07ae717e1..d643912922 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -3162,7 +3162,7 @@ static int parse_stream_outer(struct in_str *inp, int flag)
 	o_string temp=NULL_O_STRING;
 	int rcode;
 #ifdef __U_BOOT__
-	int code = 0;
+	int code = 1;
 #endif
 	do {
 		ctx.type = flag;
diff --git a/test/command_ut.c b/test/command_ut.c
index a4f034179b..926573a395 100644
--- a/test/command_ut.c
+++ b/test/command_ut.c
@@ -191,6 +191,8 @@ static int do_ut_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	assert(run_command("", 0) == 0);
 	assert(run_command(" ", 0) == 0);
 
+	assert(run_command("'", 0) == 1);
+
 	printf("%s: Everything went swimmingly\n", __func__);
 	return 0;
 }