efi_loader: fix memory freeing in efi_get_dp_from_boot()

efi_get_var() allocates memory which must be freed after the variable is
used. Since the device path is duplicated after we deserialize the load
options free the memory used for the variable payload

Fixes: db61e70e0d2a efi_loader: efi_dp_from_lo() should skip VenMedia node
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Heinric Schuchardt <heinrich.schuchardt@canonical.com>

diff --git a/lib/efi_loader/efi_helper.c b/lib/efi_loader/efi_helper.c
index 65d2116381aee8fbf19a3a9a6169c56c5d524493..916f43da26c78e4eee5e50e319d9b2e2f580435a 100644 (file)
--- a/lib/efi_loader/efi_helper.c
+++ b/lib/efi_loader/efi_helper.c
@@ -74,6 +74,7 @@ out:
  */
 struct efi_device_path *efi_get_dp_from_boot(const efi_guid_t *guid)
 {
+       struct efi_device_path *file_path = NULL;
        struct efi_load_option lo;
        void *var_value;
        efi_uintn_t size;
@@ -92,11 +93,11 @@ struct efi_device_path *efi_get_dp_from_boot(const efi_guid_t *guid)
        if (ret != EFI_SUCCESS)
                goto err;
 
-       return efi_dp_from_lo(&lo, guid);
+       file_path = efi_dp_from_lo(&lo, guid);
 
 err:
        free(var_value);
-       return NULL;
+       return file_path;
 }
 
 /**