]> git.dujemihanovic.xyz Git - u-boot.git/commit
board: microchip: icicle: correct type for node offset
authorConor Dooley <conor.dooley@microchip.com>
Wed, 15 May 2024 15:04:30 +0000 (16:04 +0100)
committerLeo Yu-Chi Liang <ycliang@andestech.com>
Thu, 30 May 2024 08:00:52 +0000 (16:00 +0800)
commitd4573c05cbea34f8d7c3c2d5e49b7b057b895882
tree127b2858abafd8549b9dd677ae8204b310473e35
parent46ff00bea5dd2dd247d5e2fdadbf5dcf8653cd9a
board: microchip: icicle: correct type for node offset

Node offsets returned by libfdt can contain negative error numbers, so
the variable type should be "int". As things stand, if the ethernet
nodes are not found in the early init callback, the if (node < 0) tests
pass and the code errors out while trying to set the local-mac-address
for a non-existent node.

Fixes: 64413e1b7c ("riscv: Add Microchip MPFS Icicle Kit support")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
board/microchip/mpfs_icicle/mpfs_icicle.c