From d32169c0fd66fcd0b8a8572b4d7dff3fb3a87599 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sat, 5 Mar 2022 20:19:07 -0700 Subject: [PATCH] binman: Update fit to move node reading into the ReadNode() method This should not be done in the constructor. Move it. Signed-off-by: Simon Glass Suggested-by: Alper Nebi Yasak Reviewed-by: Alper Nebi Yasak --- tools/binman/etype/fit.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index 9bc25888e8..4858ad4dd1 100644 --- a/tools/binman/etype/fit.py +++ b/tools/binman/etype/fit.py @@ -168,12 +168,14 @@ class Entry_fit(Entry_section): super().__init__(section, etype, node) self._fit = None self._fit_props = {} + self._fdts = None + self.mkimage = None + def ReadNode(self): + super().ReadNode() for pname, prop in self._node.props.items(): if pname.startswith('fit,'): self._fit_props[pname] = prop - - self._fdts = None self._fit_list_prop = self._fit_props.get('fit,fdt-list') if self._fit_list_prop: fdts, = self.GetEntryArgsOrProps( @@ -182,10 +184,6 @@ class Entry_fit(Entry_section): self._fdts = fdts.split() self._fit_default_dt = self.GetEntryArgsOrProps([EntryArg('default-dt', str)])[0] - self.mkimage = None - - def ReadNode(self): - super().ReadNode() def _get_operation(self, subnode): """Get the operation referenced by a subnode -- 2.39.5