From 4ac5620270ddc5b31cf8600ffa5990be197597c9 Mon Sep 17 00:00:00 2001 From: Alessandro Rubini Date: Sun, 3 Dec 2023 18:08:26 +0100 Subject: [PATCH] tools: mxsboot: pre-fill buffer with 0xff, not 0 The tool works for me, with imx28 and NAND memory, but the resulting blocks are reported as bad, both by u-boot and the kernel. This makes it impossible to erase from Linux (for an upgrade without console access, for example -- u-boot can "nand scrub" but linux can't). pre-filling with 0xff creates a proper boot loader image, but no bad-block marker is there when written to flash. Signed-off-by: Alessandro Rubini Reviewed-by: Fabio Estevam Reviewed-by: Marek Vasut --- tools/mxsboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/mxsboot.c b/tools/mxsboot.c index 04d86f87a8..8f4018aa56 100644 --- a/tools/mxsboot.c +++ b/tools/mxsboot.c @@ -478,7 +478,7 @@ static int mx28_create_nand_image(int infd, int outfd) goto err0; } - memset(buf, 0, size); + memset(buf, 0xff, size); fcb = mx28_nand_get_fcb(MAX_BOOTSTREAM_SIZE); if (!fcb) { -- 2.39.5