From 2ab7ef74cd90a6d60df6aad7dac24b6a2bb1fe85 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Sun, 25 Nov 2018 20:14:36 -0700 Subject: [PATCH] efi: Check for failure to create objects in selftest At present a few error conditions are not checked. Before refactoring this code, add some basic checks. Note that this code still leaks memory in the event of error. This will be tackled after the refactor. Signed-off-by: Simon Glass Signed-off-by: Alexander Graf --- cmd/bootefi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/bootefi.c b/cmd/bootefi.c index 3e37805ea1..5be10c9b83 100644 --- a/cmd/bootefi.c +++ b/cmd/bootefi.c @@ -532,7 +532,12 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) bootefi_device_path = efi_dp_from_mem(EFI_RESERVED_MEMORY_TYPE, (uintptr_t)&efi_selftest, (uintptr_t)&efi_selftest); + if (!bootefi_device_path) + return CMD_RET_FAILURE; + bootefi_image_path = efi_dp_from_file(NULL, 0, "\\selftest"); + if (!bootefi_image_path) + return CMD_RET_FAILURE; r = efi_setup_loaded_image(bootefi_device_path, bootefi_image_path, &image_obj, -- 2.39.5