From 0d57718775243c2d2d7ff8c69dad83db08e1030d Mon Sep 17 00:00:00 2001 From: Bin Meng Date: Sun, 26 Jun 2016 23:24:30 -0700 Subject: [PATCH] tools: patman: Generate cover letter correctly when 'END' is missing If 'END' is missing in a 'Cover-letter' section, and that section happens to show up at the very end of the commit message, and the commit is the last commit of the series, patman fails to generate cover letter for us. Handle this in CloseCommit of patchstream. Signed-off-by: Bin Meng Acked-by: Simon Glass --- tools/patman/patchstream.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index ce8ffb86bf..9ae977f2df 100644 --- a/tools/patman/patchstream.py +++ b/tools/patman/patchstream.py @@ -112,6 +112,14 @@ class PatchStream: if self.commit and self.is_log: self.series.AddCommit(self.commit) self.commit = None + # If 'END' is missing in a 'Cover-letter' section, and that section + # happens to show up at the very end of the commit message, this is + # the chance for us to fix it up. + if self.in_section == 'cover' and self.is_log: + self.series.cover = self.section + self.in_section = None + self.skip_blank = True + self.section = [] def ProcessLine(self, line): """Process a single line of a patch file or commit log -- 2.39.5