From: Lokesh Vutla <lokeshvutla@ti.com>
Date: Fri, 11 Jan 2019 09:45:50 +0000 (+0530)
Subject: Revert "power: regulator: Return success on attempt to disable an always-on regulator"
X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=f93fab312615ce0bc9aac33f9dcd876a3fed1290;p=u-boot.git

Revert "power: regulator: Return success on attempt to disable an always-on regulator"

This reverts commit e17e0ceb83538c015a50b965547f2f4d38f81c5d.

It is advised to return an error when trying to disable an always-on
regulator and let the consumer driver handle the error if needed.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---

diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
index 39e46279d5..4511625ff2 100644
--- a/drivers/power/regulator/regulator-uclass.c
+++ b/drivers/power/regulator/regulator-uclass.c
@@ -113,7 +113,7 @@ int regulator_set_enable(struct udevice *dev, bool enable)
 
 	uc_pdata = dev_get_uclass_platdata(dev);
 	if (!enable && uc_pdata->always_on)
-		return 0;
+		return -EACCES;
 
 	return ops->set_enable(dev, enable);
 }