From: Patrick Delaunay <patrick.delaunay@foss.st.com>
Date: Wed, 24 Feb 2021 10:52:35 +0000 (+0100)
Subject: env: sf: add missing spi_flash_free
X-Git-Tag: v2025.01-rc5-pxa1908~1917^2~1
X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=c2d00364c1d638eaa85d5f1384170f610b3c4beb;p=u-boot.git

env: sf: add missing spi_flash_free

Free the SPI resources by calling spi_flash_free() in each env sf
function to avoid issue for other SPI users.

Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
---

diff --git a/env/sf.c b/env/sf.c
index 1c2ab9da9b..ba5f7919c1 100644
--- a/env/sf.c
+++ b/env/sf.c
@@ -154,6 +154,9 @@ static int env_sf_save(void)
 	printf("Valid environment: %d\n", (int)gd->env_valid);
 
 done:
+	spi_flash_free(env_flash);
+	env_flash = NULL;
+
 	if (saved_buffer)
 		free(saved_buffer);
 
@@ -255,6 +258,9 @@ static int env_sf_save(void)
 	puts("done\n");
 
 done:
+	spi_flash_free(env_flash);
+	env_flash = NULL;
+
 	if (saved_buffer)
 		free(saved_buffer);
 
@@ -413,6 +419,9 @@ static int env_sf_init_early(void)
 		gd->env_addr = (unsigned long)&tmp_env1->data;
 	}
 
+	spi_flash_free(env_flash);
+	env_flash = NULL;
+
 	return 0;
 err_read:
 	spi_flash_free(env_flash);