From: Simon Glass <sjg@chromium.org>
Date: Wed, 31 Jul 2024 14:49:03 +0000 (-0600)
Subject: binman: Return failure when a usage() message is generated
X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=ba35f730e817153f07ea88355399ab336319f8a7;p=u-boot.git

binman: Return failure when a usage() message is generated

The tool must return an error code when invalid arguments are provided,
otherwise binman has no way of knowing that anything went wrong.

Correct this.

Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: fab430be2f4 ("tools: add mkeficapsule command for UEFI...")
---

diff --git a/tools/mkeficapsule.c b/tools/mkeficapsule.c
index c112ae2de8..f28008a082 100644
--- a/tools/mkeficapsule.c
+++ b/tools/mkeficapsule.c
@@ -977,7 +977,7 @@ int main(int argc, char **argv)
 			exit(EXIT_SUCCESS);
 		default:
 			print_usage();
-			exit(EXIT_SUCCESS);
+			exit(EXIT_FAILURE);
 		}
 	}