From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 27 Jul 2023 07:15:01 +0000 (+0300)
Subject: efi_loader: fix uninitialized variable bug in efi_set_load_options()
X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=a7eb8aeccb8a6a574c8c8bac22c8e61ec425fea1;p=u-boot.git

efi_loader: fix uninitialized variable bug in efi_set_load_options()

Check for efi_search_protocol() failure before dereferencing "handler"
to avoid a crash.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---

diff --git a/lib/efi_loader/efi_load_options.c b/lib/efi_loader/efi_load_options.c
index 3cfddee014..5f62184da1 100644
--- a/lib/efi_loader/efi_load_options.c
+++ b/lib/efi_loader/efi_load_options.c
@@ -31,10 +31,10 @@ efi_status_t efi_set_load_options(efi_handle_t handle,
 	efi_status_t ret;
 
 	ret = efi_search_protocol(handle, &efi_guid_loaded_image, &handler);
-	loaded_image_info = handler->protocol_interface;
 	if (ret != EFI_SUCCESS)
 		return EFI_INVALID_PARAMETER;
 
+	loaded_image_info = handler->protocol_interface;
 	loaded_image_info->load_options = load_options;
 	loaded_image_info->load_options_size = load_options_size;