From: Fabio Estevam Date: Sat, 6 May 2023 16:14:02 +0000 (-0300) Subject: power: imx8m-power-domain: Add delay to align with kernel driver X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=8f70f3df6201f28ac0ea604840d1c0e62d521629;p=u-boot.git power: imx8m-power-domain: Add delay to align with kernel driver In the imx8m power domain kernel driver, there is an extra udelay(5) prior to requesting the domain to power up: https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375 Haven't observed any issues due to the lack of this delay in U-Boot yet, but better to align it with the kernel driver implementation. Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut --- diff --git a/drivers/power/domain/imx8m-power-domain.c b/drivers/power/domain/imx8m-power-domain.c index 145f6ec0cd..df5d7d6956 100644 --- a/drivers/power/domain/imx8m-power-domain.c +++ b/drivers/power/domain/imx8m-power-domain.c @@ -338,6 +338,9 @@ static int imx8m_power_domain_on(struct power_domain *power_domain) } } + /* delay for reset to propagate */ + udelay(5); + if (domain->bits.pxx) { /* request the domain to power up */ setbits_le32(base + regs->pup, domain->bits.pxx);