From: Neil Armstrong Date: Tue, 20 Apr 2021 08:42:26 +0000 (+0200) Subject: reset: fix reset_get_by_index_nodev index handling X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=67e69660781dac57f4a2347e4ae30d97698f245b;p=u-boot.git reset: fix reset_get_by_index_nodev index handling This fixes an issue getting resets index 1 and 3+, the spurius "> 0" made it return the index 0 or 1, whatever index was passed. The dm_test_reset_base() did not catch it, but the dm_test_reset_base() extension catches it and this fixes the regression. This also fixes a reggression on Amlogic G12A/G12B SoCs, where HDMI output was disable even when Linux was booting. Fixes: ea9dc35aab ("reset: Get the RESET by index without device") Reported-by: B1oHazard Signed-off-by: Neil Armstrong --- diff --git a/drivers/reset/reset-uclass.c b/drivers/reset/reset-uclass.c index 071c389ca0..ac89eaf098 100644 --- a/drivers/reset/reset-uclass.c +++ b/drivers/reset/reset-uclass.c @@ -95,7 +95,7 @@ int reset_get_by_index_nodev(ofnode node, int index, int ret; ret = ofnode_parse_phandle_with_args(node, "resets", "#reset-cells", 0, - index > 0, &args); + index, &args); return reset_get_by_index_tail(ret, node, &args, "resets", index > 0, reset_ctl);