From: Melin Tomas <tomas.melin@vaisala.com>
Date: Fri, 28 Jun 2019 12:08:31 +0000 (+0000)
Subject: xilinx_xiic: Fix fill tx fifo loop
X-Git-Tag: v2025.01-rc5-pxa1908~2892^2~2
X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=5324e8ef6c3d6b6183b3aadeadeeb7822b4fd68a;p=u-boot.git

xilinx_xiic: Fix fill tx fifo loop

Comparison should be against the actual message length, not loop index.

len is used for stopping while loop, pos is position in message.
stop should be sent when entire message is sent, not when
len and pos meet.

hs: fixed DOS line endings

Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---

diff --git a/drivers/i2c/xilinx_xiic.c b/drivers/i2c/xilinx_xiic.c
index 83114ed510..e4ca0ab936 100644
--- a/drivers/i2c/xilinx_xiic.c
+++ b/drivers/i2c/xilinx_xiic.c
@@ -149,7 +149,7 @@ static void xiic_fill_tx_fifo(struct xilinx_xiic_priv *priv,
 	while (len--) {
 		u16 data = msg->buf[pos++];
 
-		if (pos == len && nmsgs == 1) {
+		if ((msg->len - pos == 0) && nmsgs == 1) {
 			/* last message in transfer -> STOP */
 			data |= XIIC_TX_DYN_STOP_MASK;
 		}