From: Vladimir Oltean Date: Sun, 14 Mar 2021 12:14:49 +0000 (+0800) Subject: net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed X-Git-Tag: v2025.01-rc5-pxa1908~1920^2~35 X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=3407c30eeb885431e603bca4ca558ce53dc96a68;p=u-boot.git net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed In drivers/net/phy/Kconfig, CONFIG_PHY_FIXED already depends on CONFIG_DM_ETH, so the function prototype definition when CONFIG_DM_ETH=n does nothing, so it can be dropped. It is also never reachable, since the whole function is already under #ifdef CONFIG_PHY_FIXED (which again, as I said, depends on CONFIG_DM_ETH=y). Signed-off-by: Vladimir Oltean Reviewed-by: Bin Meng Tested-by: Bin Meng Message-Id: <20210216224804.3355044-3-olteanv@gmail.com> Signed-off-by: Bin Meng Reviewed-by: Vladimir Oltean Reviewed-by: Priyanka Jain --- diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 2feb559bba..eae40cc0d6 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1012,15 +1012,9 @@ struct phy_device *fixed_phy_create(ofnode node) return phydev; } -#ifdef CONFIG_DM_ETH static struct phy_device *phy_connect_fixed(struct mii_dev *bus, struct udevice *dev, phy_interface_t interface) -#else -static struct phy_device *phy_connect_fixed(struct mii_dev *bus, - struct eth_device *dev, - phy_interface_t interface) -#endif { ofnode node = dev_ofnode(dev), subnode; struct phy_device *phydev;