From: Nishanth Menon Date: Fri, 14 Apr 2023 22:06:43 +0000 (-0500) Subject: net: phy: dp83867: Explicitly check against sgmii X-Git-Url: http://git.dujemihanovic.xyz/login.html?a=commitdiff_plain;h=0207403eebec7f0918d84003666c30c4d0067197;p=u-boot.git net: phy: dp83867: Explicitly check against sgmii dp83867 driver only supports sgmii and not all the newer protocols. Drop the usage of the generic phy_interface_is_sgmii function and just matchup to the specific mode supported. Reported-by: Tom Rini Suggested-by: Marek Vasut Suggested-by: Marek BehĂșn Link: https://lore.kernel.org/all/b82ac325-4818-8e72-054b-640268dbf806@mailbox.org/ Signed-off-by: Nishanth Menon Reviewed-by: Ramon Fried --- diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index b861bf7cef..7111e36aa0 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -330,7 +330,7 @@ static int dp83867_config(struct phy_device *phydev) DP83867_RGMIIDCTL, delay); } - if (phy_interface_is_sgmii(phydev)) { + if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { if (dp83867->sgmii_ref_clk_en) phy_write_mmd(phydev, DP83867_DEVADDR, DP83867_SGMIICTL, DP83867_SGMII_TYPE);