firmware: zynqmp: Check if rx channel dev pointer is valid

Check if rx channel dev pointer is valid and not if the address of the
pointer is valid.

Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
Link: https://lore.kernel.org/r/20220620163650.18756-1-stefan.herbrechtsmeier-oss@weidmueller.com
Signed-off-by: Michal Simek <michal.simek@amd.com>

diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
index 0f0d2b07c00597bcb3a7534cb1cb0ed18f76a640..341d7cf1358891f0226665905a00924dbb845408 100644 (file)
--- a/drivers/firmware/firmware-zynqmp.c
+++ b/drivers/firmware/firmware-zynqmp.c
@@ -92,7 +92,7 @@ static int ipi_req(const u32 *req, size_t req_len, u32 *res, size_t res_maxlen)
            res_maxlen > PMUFW_PAYLOAD_ARG_CNT)
                return -EINVAL;
 
-       if (!(zynqmp_power.tx_chan.dev) || !(&zynqmp_power.rx_chan.dev))
+       if (!(zynqmp_power.tx_chan.dev) || !(zynqmp_power.rx_chan.dev))
                return -EINVAL;
 
        debug("%s, Sending IPI message with ID: 0x%0x\n", __func__, req[0]);