sysreset: Tidy up a few comments and logging

Some comments are incorrect or missing pieces. Fix these and use logging
to print the error.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/sysreset/sysreset-uclass.c b/drivers/sysreset/sysreset-uclass.c
index 06ef0ed96c77605d1b853d6a9722ff953da4066b..e38814b3ed1218f539b41dfccb22c9643072feaa 100644 (file)
--- a/drivers/sysreset/sysreset-uclass.c
+++ b/drivers/sysreset/sysreset-uclass.c
@@ -4,6 +4,8 @@
  * Written by Simon Glass <sjg@chromium.org>
  */
 
+#define LOG_CATEGORY UCLASS_SYSRESET
+
 #include <common.h>
 #include <sysreset.h>
 #include <dm.h>
@@ -64,7 +66,7 @@ void sysreset_walk_halt(enum sysreset_t type)
                mdelay(100);
 
        /* Still no reset? Give up */
-       debug("System reset not supported on this platform\n");
+       log_err("System reset not supported on this platform\n");
        hang();
 }
 

diff --git a/include/sysreset.h b/include/sysreset.h
index a5c0b74a4736e387e14516bf8a424d5f621fa7d7..343e46f1aa55081ec76b642b335686e011748987 100644 (file)
--- a/include/sysreset.h
+++ b/include/sysreset.h
@@ -31,6 +31,7 @@ struct sysreset_ops {
        /**
         * get_status() - get printable reset status information
         *
+        * @dev:        Device to check
         * @buf:        Buffer to receive the textual reset information
         * @size:       Size of the passed buffer
         * @return 0 if OK, -ve on error
@@ -49,8 +50,9 @@ struct sysreset_ops {
 int sysreset_request(struct udevice *dev, enum sysreset_t type);
 
 /**
- * get_status() - get printable reset status information
+ * sysreset_get_status() - get printable reset status information
  *
+ * @dev:       Device to check
  * @buf:       Buffer to receive the textual reset information
  * @size:      Size of the passed buffer
  * @return 0 if OK, -ve on error

diff --git a/test/dm/sysreset.c b/test/dm/sysreset.c
index 04d4621d9e1ab7fd388f93e1086fae4135e0ab53..218cc239cc6433726a9f59bcbf693e7e9426f0c8 100644 (file)
--- a/test/dm/sysreset.c
+++ b/test/dm/sysreset.c
@@ -62,7 +62,6 @@ static int dm_test_sysreset_get_status(struct unit_test_state *uts)
 
        return 0;
 }
-
 DM_TEST(dm_test_sysreset_get_status, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
 
 /* Test that we can walk through the sysreset devices */