x86: fsp: Move common dram functions into a common file

Most of the DRAM functionality can be shared between FSP1 and FSP2. Move
it into a shared file.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
[bmeng: rebase the patch against u-boot-x86/next to get it applied cleanly]
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

diff --git a/arch/x86/include/asm/fsp/fsp_support.h b/arch/x86/include/asm/fsp/fsp_support.h
index a6b32bf95df2db6d2e66c7e502545b6906d201e7..215b0f7c9d5d9de30fb5862a3a78be7504669a25 100644 (file)
--- a/arch/x86/include/asm/fsp/fsp_support.h
+++ b/arch/x86/include/asm/fsp/fsp_support.h
@@ -122,4 +122,13 @@ void *fsp_get_graphics_info(const void *hob_list, u32 *len);
  */
 int fsp_init_phase_pci(void);
 
+/**
+ * fsp_scan_for_ram_size() - Scan the HOB list to find the RAM size
+ *
+ * This sets gd->ram_size based on what it finds.
+ *
+ * @return 0 if OK, -ve on error
+ */
+int fsp_scan_for_ram_size(void);
+
 #endif

diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile
index a8c7448ee45f4c5819b550ad09bacf43ad548476..ca0ca1066b04856a1d052aac4b03e67aeff5fd31 100644 (file)
--- a/arch/x86/lib/Makefile
+++ b/arch/x86/lib/Makefile
@@ -43,6 +43,7 @@ ifndef CONFIG_SPL_BUILD
 obj-$(CONFIG_CMD_ZBOOT)        += zimage.o
 endif
 obj-$(CONFIG_USE_HOB) += hob.o
+obj-$(CONFIG_HAVE_FSP) += fsp/
 obj-$(CONFIG_FSP_VERSION1) += fsp1/
 obj-$(CONFIG_FSP_VERSION2) += fsp2/
 

diff --git a/arch/x86/lib/fsp/Makefile b/arch/x86/lib/fsp/Makefile
new file mode 100644 (file)
index 0000000..e216065
--- /dev/null
+++ b/arch/x86/lib/fsp/Makefile
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright 2019 Google LLC
+
+obj-y += fsp_dram.o

diff --git a/arch/x86/lib/fsp/fsp_dram.c b/arch/x86/lib/fsp/fsp_dram.c
new file mode 100644 (file)
index 0000000..8fe1e0b
--- /dev/null
+++ b/arch/x86/lib/fsp/fsp_dram.c
@@ -0,0 +1,90 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2014, Bin Meng <bmeng.cn@gmail.com>
+ */
+
+#include <common.h>
+#include <handoff.h>
+#include <asm/fsp/fsp_support.h>
+#include <asm/e820.h>
+#include <asm/mrccache.h>
+#include <asm/post.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int fsp_scan_for_ram_size(void)
+{
+       phys_size_t ram_size = 0;
+       const struct hob_header *hdr;
+       struct hob_res_desc *res_desc;
+
+       hdr = gd->arch.hob_list;
+       while (!end_of_hob(hdr)) {
+               if (hdr->type == HOB_TYPE_RES_DESC) {
+                       res_desc = (struct hob_res_desc *)hdr;
+                       if (res_desc->type == RES_SYS_MEM ||
+                           res_desc->type == RES_MEM_RESERVED)
+                               ram_size += res_desc->len;
+               }
+               hdr = get_next_hob(hdr);
+       }
+
+       gd->ram_size = ram_size;
+       post_code(POST_DRAM);
+
+       return 0;
+};
+
+int dram_init_banksize(void)
+{
+       gd->bd->bi_dram[0].start = 0;
+       gd->bd->bi_dram[0].size = gd->ram_size;
+
+       return 0;
+}
+
+unsigned int install_e820_map(unsigned int max_entries,
+                             struct e820_entry *entries)
+{
+       unsigned int num_entries = 0;
+       const struct hob_header *hdr;
+       struct hob_res_desc *res_desc;
+
+       hdr = gd->arch.hob_list;
+
+       while (!end_of_hob(hdr)) {
+               if (hdr->type == HOB_TYPE_RES_DESC) {
+                       res_desc = (struct hob_res_desc *)hdr;
+                       entries[num_entries].addr = res_desc->phys_start;
+                       entries[num_entries].size = res_desc->len;
+
+                       if (res_desc->type == RES_SYS_MEM)
+                               entries[num_entries].type = E820_RAM;
+                       else if (res_desc->type == RES_MEM_RESERVED)
+                               entries[num_entries].type = E820_RESERVED;
+
+                       num_entries++;
+               }
+               hdr = get_next_hob(hdr);
+       }
+
+       /* Mark PCIe ECAM address range as reserved */
+       entries[num_entries].addr = CONFIG_PCIE_ECAM_BASE;
+       entries[num_entries].size = CONFIG_PCIE_ECAM_SIZE;
+       entries[num_entries].type = E820_RESERVED;
+       num_entries++;
+
+#ifdef CONFIG_HAVE_ACPI_RESUME
+       /*
+        * Everything between U-Boot's stack and ram top needs to be
+        * reserved in order for ACPI S3 resume to work.
+        */
+       entries[num_entries].addr = gd->start_addr_sp - CONFIG_STACK_SIZE;
+       entries[num_entries].size = gd->ram_top - gd->start_addr_sp +
+               CONFIG_STACK_SIZE;
+       entries[num_entries].type = E820_RESERVED;
+       num_entries++;
+#endif
+
+       return num_entries;
+}

diff --git a/arch/x86/lib/fsp1/fsp_dram.c b/arch/x86/lib/fsp1/fsp_dram.c
index 75341bc52872e1becf4ead5043fce175e7e8197d..6a3349b42af23f2aa896d17fab6ff89dcf8b9e08 100644 (file)
--- a/arch/x86/lib/fsp1/fsp_dram.c
+++ b/arch/x86/lib/fsp1/fsp_dram.c
@@ -4,33 +4,16 @@
  */
 
 #include <common.h>
-#include <asm/fsp1/fsp_support.h>
-#include <asm/e820.h>
-#include <asm/mrccache.h>
-#include <asm/post.h>
-
-DECLARE_GLOBAL_DATA_PTR;
+#include <asm/fsp/fsp_support.h>
 
 int dram_init(void)
 {
-       phys_size_t ram_size = 0;
-       const struct hob_header *hdr;
-       struct hob_res_desc *res_desc;
-
-       hdr = gd->arch.hob_list;
-       while (!end_of_hob(hdr)) {
-               if (hdr->type == HOB_TYPE_RES_DESC) {
-                       res_desc = (struct hob_res_desc *)hdr;
-                       if (res_desc->type == RES_SYS_MEM ||
-                           res_desc->type == RES_MEM_RESERVED) {
-                               ram_size += res_desc->len;
-                       }
-               }
-               hdr = get_next_hob(hdr);
-       }
+       int ret;
 
-       gd->ram_size = ram_size;
-       post_code(POST_DRAM);
+       /* The FSP has already set up DRAM, so grab the info we need */
+       ret = fsp_scan_for_ram_size();
+       if (ret)
+               return ret;
 
        if (IS_ENABLED(CONFIG_ENABLE_MRC_CACHE))
                gd->arch.mrc_output = fsp_get_nvs_data(gd->arch.hob_list,
@@ -39,14 +22,6 @@ int dram_init(void)
        return 0;
 }
 
-int dram_init_banksize(void)
-{
-       gd->bd->bi_dram[0].start = 0;
-       gd->bd->bi_dram[0].size = gd->ram_size;
-
-       return 0;
-}
-
 /*
  * This function looks for the highest region of memory lower than 4GB which
  * has enough space for U-Boot where U-Boot is aligned on a page boundary.
@@ -59,49 +34,3 @@ ulong board_get_usable_ram_top(ulong total_size)
 {
        return fsp_get_usable_lowmem_top(gd->arch.hob_list);
 }
-
-unsigned int install_e820_map(unsigned int max_entries,
-                             struct e820_entry *entries)
-{
-       unsigned int num_entries = 0;
-       const struct hob_header *hdr;
-       struct hob_res_desc *res_desc;
-
-       hdr = gd->arch.hob_list;
-
-       while (!end_of_hob(hdr)) {
-               if (hdr->type == HOB_TYPE_RES_DESC) {
-                       res_desc = (struct hob_res_desc *)hdr;
-                       entries[num_entries].addr = res_desc->phys_start;
-                       entries[num_entries].size = res_desc->len;
-
-                       if (res_desc->type == RES_SYS_MEM)
-                               entries[num_entries].type = E820_RAM;
-                       else if (res_desc->type == RES_MEM_RESERVED)
-                               entries[num_entries].type = E820_RESERVED;
-
-                       num_entries++;
-               }
-               hdr = get_next_hob(hdr);
-       }
-
-       /* Mark PCIe ECAM address range as reserved */
-       entries[num_entries].addr = CONFIG_PCIE_ECAM_BASE;
-       entries[num_entries].size = CONFIG_PCIE_ECAM_SIZE;
-       entries[num_entries].type = E820_RESERVED;
-       num_entries++;
-
-#ifdef CONFIG_HAVE_ACPI_RESUME
-       /*
-        * Everything between U-Boot's stack and ram top needs to be
-        * reserved in order for ACPI S3 resume to work.
-        */
-       entries[num_entries].addr = gd->start_addr_sp - CONFIG_STACK_SIZE;
-       entries[num_entries].size = gd->ram_top - gd->start_addr_sp + \
-               CONFIG_STACK_SIZE;
-       entries[num_entries].type = E820_RESERVED;
-       num_entries++;
-#endif
-
-       return num_entries;
-}