]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: ravb: Support fixed PHY in R-Car
authorMikhail Lappo <mikhail.lappo@esrlabs.com>
Mon, 27 Feb 2023 23:04:11 +0000 (00:04 +0100)
committerMarek Vasut <marek.vasut+renesas@mailbox.org>
Sat, 18 Mar 2023 11:02:38 +0000 (12:02 +0100)
Calling old U-Boot API doesn't allow to use fixed PHY.
Searching by mask is the part of new function, after
scanning FDT for a fixed PHY definition

Fixes: e821a7bdb13 ("net: ravb: Detect PHY correctly")
Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Signed-off-by: Mikhail Lappo <mikhail.lappo@esrlabs.com>
Signed-off-by: Hai Pham <hai.pham.ud@renesas.com>
[Hai Pham: Drop phy_connect_dev since it's called in phy_connect]
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
[Marek: Use mask -1 instead of 0 to reinstate the search behavior
        over all PHY addresses. Add Fixes tag, sort the tag list.]

drivers/net/ravb.c

index 5a835cc06ff20b9bb39162a7bcb91122c3f6aa18..0bc50dc733529f1c17b2d0f4979ad8e1c9e1168b 100644 (file)
@@ -310,7 +310,7 @@ static int ravb_phy_config(struct udevice *dev)
        struct ravb_priv *eth = dev_get_priv(dev);
        struct eth_pdata *pdata = dev_get_plat(dev);
        struct phy_device *phydev;
-       int mask = 0xffffffff, reg;
+       int reg;
 
        if (dm_gpio_is_valid(&eth->reset_gpio)) {
                dm_gpio_set_value(&eth->reset_gpio, 1);
@@ -319,12 +319,10 @@ static int ravb_phy_config(struct udevice *dev)
                mdelay(1);
        }
 
-       phydev = phy_find_by_mask(eth->bus, mask);
+       phydev = phy_connect(eth->bus, -1, dev, pdata->phy_interface);
        if (!phydev)
                return -ENODEV;
 
-       phy_connect_dev(phydev, dev, pdata->phy_interface);
-
        eth->phydev = phydev;
 
        phydev->supported &= SUPPORTED_100baseT_Full |