]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mmc: tangier_sdhci: fix uninitialized pointer deref on probe
authorPeng Fan <peng.fan@nxp.com>
Tue, 6 Aug 2019 02:48:04 +0000 (02:48 +0000)
committerPeng Fan <peng.fan@nxp.com>
Fri, 9 Aug 2019 05:45:25 +0000 (13:45 +0800)
Commit 3d296365e4e8 ("mmc: sdhci: Add support for
sdhci-caps-mask") sdhci_setup_cfg() expects a valid sdhci_host mmc
field.

Fixes: 3d296365e4e8 ("mmc: sdhci: Add support for sdhci-caps-mask")
Cc: Faiz Abbas <faiz_abbas@ti.com>
Cc: Vincent Tinelli <vincent.tinelli@intel.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/mmc/tangier_sdhci.c

index 4c33356b9fccd9caa1ef9e9456427847fe6ec3ab..0d6e5d62460b375c7b0a16934fd78a623e82a340 100644 (file)
@@ -51,13 +51,14 @@ static int sdhci_tangier_probe(struct udevice *dev)
        /* MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195 */
        host->voltages = MMC_VDD_165_195;
 
+       host->mmc = &plat->mmc;
+       host->mmc->dev = dev;
        ret = sdhci_setup_cfg(&plat->cfg, host, SDHCI_TANGIER_FMAX,
                        SDHCI_TANGIER_FMIN);
        if (ret)
                return ret;
 
        upriv->mmc = &plat->mmc;
-       host->mmc = &plat->mmc;
        host->mmc->priv = host;
 
        return sdhci_probe(dev);