]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: mvpp2: remove redundant SMI address configuration
authorMarcin Wojtas <mw@semihalf.com>
Mon, 3 May 2021 06:08:47 +0000 (08:08 +0200)
committerStefan Roese <sr@denx.de>
Thu, 20 May 2021 11:03:30 +0000 (13:03 +0200)
Because the mvpp2 driver now relies on the PHYLIB and
the external MDIO driver, configuring low level
SMI bus settings is redundant.

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Kostya Porotchkin <kostap@marvell.com>
Reviewed-by: Stefan Chulski <stefanc@marvell.com>
Signed-off-by: Stefan Roese <sr@denx.de>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
drivers/net/mvpp2.c

index 847007d5b487bf94946c1676d76c449531bed5fd..2043bdf10aa432a2c2dc6576b58465ba4615e60d 100644 (file)
@@ -5292,14 +5292,6 @@ static int mvpp2_write_hwaddr(struct udevice *dev)
        return mvpp2_prs_update_mac_da(port, port->dev_addr);
 }
 
-static int mvpp22_smi_phy_addr_cfg(struct mvpp2_port *port)
-{
-       writel(port->phyaddr, port->priv->iface_base +
-              MVPP22_SMI_PHY_ADDR_REG(port->gop_id));
-
-       return 0;
-}
-
 static int mvpp2_base_probe(struct udevice *dev)
 {
        struct mvpp2 *priv = dev_get_priv(dev);
@@ -5422,10 +5414,6 @@ static int mvpp2_probe(struct udevice *dev)
                port->base = priv->iface_base + MVPP22_PORT_BASE +
                        port->gop_id * MVPP22_PORT_OFFSET;
 
-               /* Set phy address of the port */
-               if (port->phyaddr < PHY_MAX_ADDR)
-                       mvpp22_smi_phy_addr_cfg(port);
-
                /* GoP Init */
                gop_port_init(port);
        }