dm: core: Swap parameters of ofnode_write_prop()

It is normal for the length to come after the value in libfdt. Follow this
same convention with ofnode.

Signed-off-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c
index bd41ef503c2067e2ad86ca08951f3b5fba6c8669..1c9542a3567d121ae753c01d44d756870e7ed221 100644 (file)
--- a/drivers/core/ofnode.c
+++ b/drivers/core/ofnode.c
@@ -1105,8 +1105,8 @@ ofnode ofnode_by_prop_value(ofnode from, const char *propname,
        }
 }
 
-int ofnode_write_prop(ofnode node, const char *propname, int len,
-                     const void *value)
+int ofnode_write_prop(ofnode node, const char *propname, const void *value,
+                     int len)
 {
        const struct device_node *np = ofnode_to_np(node);
        struct property *pp;
@@ -1161,7 +1161,7 @@ int ofnode_write_string(ofnode node, const char *propname, const char *value)
 
        debug("%s: %s = %s", __func__, propname, value);
 
-       return ofnode_write_prop(node, propname, strlen(value) + 1, value);
+       return ofnode_write_prop(node, propname, value, strlen(value) + 1);
 }
 
 int ofnode_set_enabled(ofnode node, bool value)

diff --git a/include/dm/ofnode.h b/include/dm/ofnode.h
index d7ad5dccc14134d0217c1c81adb7ac27bfb8a29d..071a9d63f67f27136699dab835fcf0d0cfa7a717 100644 (file)
--- a/include/dm/ofnode.h
+++ b/include/dm/ofnode.h
@@ -1114,13 +1114,13 @@ int ofnode_device_is_compatible(ofnode node, const char *compat);
  *
  * @node:      The node for whose property should be set
  * @propname:  The name of the property to set
- * @len:       The length of the new value of the property
  * @value:     The new value of the property (must be valid prior to calling
  *             the function)
+ * @len:       The length of the new value of the property
  * Return: 0 if successful, -ve on error
  */
-int ofnode_write_prop(ofnode node, const char *propname, int len,
-                     const void *value);
+int ofnode_write_prop(ofnode node, const char *propname, const void *value,
+                     int len);
 
 /**
  * ofnode_write_string() - Set a string property of a ofnode

diff --git a/test/dm/ofnode.c b/test/dm/ofnode.c
index b8d8e440dbcab952780f2dba56e4d23dc095c9f0..0aeaaeb7f8c9f030d86ffa9201f7c717b8256551 100644 (file)
--- a/test/dm/ofnode.c
+++ b/test/dm/ofnode.c
@@ -576,8 +576,8 @@ static int dm_test_ofnode_livetree_writing(struct unit_test_state *uts)
        /* Non-existent in DTB */
        ut_asserteq_64(FDT_ADDR_T_NONE, dev_read_addr(dev));
        /* reg = 0x42, size = 0x100 */
-       ut_assertok(ofnode_write_prop(node, "reg", 8,
-                                     "\x00\x00\x00\x42\x00\x00\x01\x00"));
+       ut_assertok(ofnode_write_prop(node, "reg",
+                                     "\x00\x00\x00\x42\x00\x00\x01\x00", 8));
        ut_asserteq(0x42, dev_read_addr(dev));
 
        /* Test disabling devices */