]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
video: nexell: Drop unused and invalid code
authorSimon Glass <sjg@chromium.org>
Sun, 23 Jan 2022 14:04:05 +0000 (07:04 -0700)
committerAnatolij Gustschin <agust@denx.de>
Mon, 28 Mar 2022 18:16:30 +0000 (20:16 +0200)
Unfortunately this driver uses the old video structure to store things.
This is not supported with driver model.

Drop the old code and comment out the other pieces, so the maintainer can
take a look.

Signed-off-by: Simon Glass <sjg@chromium.org>
arch/arm/mach-nexell/include/mach/display_dev.h
drivers/video/nexell_display.c

index 77eb614768c72b5f15352dd8c7478e1fe2aa9c4c..0dd96f6795760c64a6d03cbeb44dbfe73f02906a 100644 (file)
@@ -15,8 +15,8 @@
 #endif
 
 struct nx_display_dev {
-#if defined CONFIG_VIDEO || defined CONFIG_DM_VIDEO
-       GraphicDevice graphic_device;
+#if defined CONFIG_DM_VIDEO
+       /* GraphicDevice graphic_device;   -- not defined anymore */
 #elif defined CONFIG_LCD
        vidinfo_t *panel_info;
 #endif
index c7621ef49c5149973ac9286314cc938a88af43aa..a0bd44c8b84e65d6fabe2e7f08a4f2707fb67910 100644 (file)
@@ -537,7 +537,6 @@ static int nx_display_probe(struct udevice *dev)
        struct video_uc_plat *uc_plat = dev_get_uclass_plat(dev);
        struct video_priv *uc_priv = dev_get_uclass_priv(dev);
        struct nx_display_plat *plat = dev_get_plat(dev);
-       static GraphicDevice *graphic_device;
        char addr[64];
 
        debug("%s()\n", __func__);
@@ -564,7 +563,7 @@ static int nx_display_probe(struct udevice *dev)
        }
 
        struct nx_display_dev *dp;
-       unsigned int pp_index = 0;
+       /* unsigned int pp_index = 0; */
 
        dp = nx_display_setup();
        if (!dp) {
@@ -574,6 +573,7 @@ static int nx_display_probe(struct udevice *dev)
        }
 
        switch (dp->depth) {
+#if 0 /* GDF_16BIT_565RGB is not defined in video.h */
        case 2:
                pp_index = GDF_16BIT_565RGB;
                uc_priv->bpix = VIDEO_BPP16;
@@ -586,6 +586,7 @@ static int nx_display_probe(struct udevice *dev)
                pp_index = GDF_32BIT_X888RGB;
                uc_priv->bpix = VIDEO_BPP32;
                break;
+#endif
        default:
                printf("fail : not support LCD bit per pixel %d\n",
                       dp->depth * 8);
@@ -596,15 +597,6 @@ static int nx_display_probe(struct udevice *dev)
        uc_priv->ysize = dp->fb_plane->height;
        uc_priv->rot = 0;
 
-       graphic_device = &dp->graphic_device;
-       graphic_device->frameAdrs = dp->fb_addr;
-       graphic_device->gdfIndex = pp_index;
-       graphic_device->gdfBytesPP = dp->depth;
-       graphic_device->winSizeX = dp->fb_plane->width;
-       graphic_device->winSizeY = dp->fb_plane->height;
-       graphic_device->plnSizeX =
-           graphic_device->winSizeX * graphic_device->gdfBytesPP;
-
        /*
         * set environment variable "fb_addr" (frame buffer address), required
         * for splash image. Because drv_video_init() in common/stdio.c is only