efi_loader: QueryMode() check parameters

Check the parameters of EFI_GRAPHICS_OUTPUT_PROTOCOL.QueryMode().

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c
index 9428c3b83cf749f00e7d19774fd8f926751ff233..c44a1cfc471b7642c7b27e482dedc0e8d3902132 100644 (file)
--- a/lib/efi_loader/efi_gop.c
+++ b/lib/efi_loader/efi_gop.c
@@ -41,14 +41,21 @@ static efi_status_t EFIAPI gop_query_mode(struct efi_gop *this, u32 mode_number,
                                          struct efi_gop_mode_info **info)
 {
        struct efi_gop_obj *gopobj;
+       efi_status_t ret = EFI_SUCCESS;
 
        EFI_ENTRY("%p, %x, %p, %p", this, mode_number, size_of_info, info);
 
+       if (!this || !size_of_info || !info || mode_number) {
+               ret = EFI_INVALID_PARAMETER;
+               goto out;
+       }
+
        gopobj = container_of(this, struct efi_gop_obj, ops);
        *size_of_info = sizeof(gopobj->info);
        *info = &gopobj->info;
 
-       return EFI_EXIT(EFI_SUCCESS);
+out:
+       return EFI_EXIT(ret);
 }
 
 static efi_status_t EFIAPI gop_set_mode(struct efi_gop *this, u32 mode_number)