pinctrl: single: check "register-width" DT property

In more recent versions of the Linux kernel the driver's probe function
returns an error if the "pinctrl-single,register-width" DT property is
missing. The lack of this information, in fact, does not allow to know
whether to access the registers of the controller at 8, 16, ... bits.

Signed-off-by: Dario Binacchi <dariobin@libero.it>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index d5656de8e8a794a8506079f9a4e0d47b4b313786..5ade1088755bb1b4e4068ee7bed12e288782c318 100644 (file)
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -22,7 +22,7 @@ struct single_pdata {
        fdt_addr_t base;
        int offset;
        u32 mask;
-       int width;
+       u32 width;
        bool bits_per_mux;
 };
 
@@ -184,9 +184,13 @@ static int single_of_to_plat(struct udevice *dev)
        fdt_addr_t addr;
        fdt_size_t size;
        struct single_pdata *pdata = dev_get_plat(dev);
+       int ret;
 
-       pdata->width =
-               dev_read_u32_default(dev, "pinctrl-single,register-width", 0);
+       ret = dev_read_u32(dev, "pinctrl-single,register-width", &pdata->width);
+       if (ret) {
+               dev_err(dev, "missing register width\n");
+               return ret;
+       }
 
        addr = dev_read_addr_size(dev, "reg", &size);
        if (addr == FDT_ADDR_T_NONE) {