]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: mvneta: Drop unneeded macro
authorMarek Behún <marek.behun@nic.cz>
Wed, 27 Apr 2022 10:42:02 +0000 (12:42 +0200)
committerStefan Roese <sr@denx.de>
Wed, 4 May 2022 05:05:51 +0000 (07:05 +0200)
Macro MVNETA_GMAC_FORCE_LINK_UP can be dropped from value assignment in
fixed link case, since it's value is written into the register later in
the function for link-down-to-link-up case. The value is written as
MVNETA_GMAC_FORCE_LINK_DOWN | MVNETA_GMAC_FORCE_LINK_PASS, and so the
macro definition can also be dropped.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
drivers/net/mvneta.c

index 292c364e5edf7dcd0614011ff1c50da22ba914fb..d2c42c4396162e96ba3d0614b7346f27680e83e3 100644 (file)
@@ -188,7 +188,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define MVNETA_GMAC_AUTONEG_CONFIG               0x2c0c
 #define      MVNETA_GMAC_FORCE_LINK_DOWN         BIT(0)
 #define      MVNETA_GMAC_FORCE_LINK_PASS         BIT(1)
-#define      MVNETA_GMAC_FORCE_LINK_UP           (BIT(0) | BIT(1))
 #define      MVNETA_GMAC_IB_BYPASS_AN_EN         BIT(3)
 #define      MVNETA_GMAC_CONFIG_MII_SPEED        BIT(5)
 #define      MVNETA_GMAC_CONFIG_GMII_SPEED       BIT(6)
@@ -1175,8 +1174,7 @@ static void mvneta_adjust_link(struct udevice *dev)
                 */
                if (CONFIG_IS_ENABLED(PHY_FIXED) &&
                    pp->phydev->phy_id == PHY_FIXED_ID)
-                       val = MVNETA_GMAC_FORCE_LINK_UP |
-                             MVNETA_GMAC_IB_BYPASS_AN_EN |
+                       val = MVNETA_GMAC_IB_BYPASS_AN_EN |
                              MVNETA_GMAC_SET_FC_EN |
                              MVNETA_GMAC_ADVERT_FC_EN |
                              MVNETA_GMAC_SAMPLE_TX_CFG_EN;