]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: phy: Only call phy_init() on systems needing manual relocation
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sun, 19 Mar 2023 17:03:17 +0000 (18:03 +0100)
committerMarek Vasut <marek.vasut+renesas@mailbox.org>
Fri, 7 Apr 2023 12:18:51 +0000 (14:18 +0200)
The phy_init() is now used only to perform manual relocation of PHY
driver callbacks. Wrap it in ifdeffery and only call it on systems
which still require manual relocation, i.e. m68k .

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Tested-by: Michal Simek <michal.simek@amd.com> #microblaze (MANUAL_RELOC)
drivers/net/phy/phy.c
net/eth_common.c

index 61603f2817918f127caa5ded804be89f8c4cc8d2..9b0e497f223b782320700dab4374c09d9423ba9c 100644 (file)
@@ -463,9 +463,9 @@ U_BOOT_PHY_DRIVER(genphy) = {
        .shutdown       = genphy_shutdown,
 };
 
+#ifdef CONFIG_NEEDS_MANUAL_RELOC
 int phy_init(void)
 {
-#ifdef CONFIG_NEEDS_MANUAL_RELOC
        const int ll_n_ents = ll_entry_count(struct phy_driver, phy_driver);
        struct phy_driver *drv, *ll_entry;
 
@@ -489,10 +489,10 @@ int phy_init(void)
                if (drv->write_mmd)
                        drv->write_mmd += gd->reloc_off;
        }
-#endif
 
        return 0;
 }
+#endif
 
 int phy_set_supported(struct phy_device *phydev, u32 max_speed)
 {
index 82d527abba67f3a49771dd9582e7cc83bbab0b69..c94a7ba6ae7ae2a1a277653d43030c18023d1bd7 100644 (file)
@@ -37,7 +37,7 @@ void eth_common_init(void)
        miiphy_init();
 #endif
 
-#ifdef CONFIG_PHYLIB
+#if defined(CONFIG_NEEDS_MANUAL_RELOC) && defined(CONFIG_PHYLIB)
        phy_init();
 #endif
 #endif