]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
board_f: Relocate fdt even if GD_FLG_SKIP_RELOC is set
authorKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Tue, 20 Jun 2023 10:50:48 +0000 (19:50 +0900)
committerTom Rini <trini@konsulko.com>
Fri, 14 Jul 2023 19:21:08 +0000 (15:21 -0400)
In case of OF_SEPARATE (!OF_EMBED), the devicetree blob is placed
after _end, and fdt_find_separate() always returns _end. There is
a .bss section after _end and the section is cleared before relocation.

When GD_FLG_SKIP_RELOC is set, relocation is skipped, so the blob is
still in .bss section, but will be cleared. As a result, the devicetree
become invalid.

To avoid this issue, should relocate it regardless of GD_FLG_SKIP_RELOC
in reloc_fdt().

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
common/board_f.c

index 1688e27071fc19c1a0c20eef4a245a5415f2d9ab..334d04af197b4e6b75b66c3a508e4864bf6bb629 100644 (file)
@@ -633,8 +633,6 @@ static int init_post(void)
 static int reloc_fdt(void)
 {
        if (!IS_ENABLED(CONFIG_OF_EMBED)) {
-               if (gd->flags & GD_FLG_SKIP_RELOC)
-                       return 0;
                if (gd->new_fdt) {
                        memcpy(gd->new_fdt, gd->fdt_blob,
                               fdt_totalsize(gd->fdt_blob));