]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
xilinx: common: fix board_late_init_xilinx()
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 8 Oct 2022 09:13:17 +0000 (11:13 +0200)
committerMichal Simek <michal.simek@amd.com>
Mon, 10 Oct 2022 10:28:08 +0000 (12:28 +0200)
Compiling with GCC-12 leads to an error:

    +board/xilinx/common/board.c:479:37: error: the comparison will always
     evaluate as 'true' for the address of 'mac_addr' will never be NULL
     [-Werror=address]
    +  479 |                                 if (!desc->mac_addr[i])
    +      |                                     ^

Remove the redundant check.

Fixes: a03b594738f8 ("xilinx: board: Add support for additional card detection")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Link: https://lore.kernel.org/r/20221008091317.52838-1-heinrich.schuchardt@canonical.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
board/xilinx/common/board.c

index bbfe84b8d0a12d5f10ff2937ca8332aa35944782..99fdbac639b7dd2e5d9c6487de5a7b46d27dbbbd 100644 (file)
@@ -476,9 +476,6 @@ int board_late_init_xilinx(void)
                                continue;
 
                        for (i = 0; i < EEPROM_HDR_NO_OF_MAC_ADDR; i++) {
-                               if (!desc->mac_addr[i])
-                                       break;
-
                                if (is_valid_ethaddr((const u8 *)desc->mac_addr[i]))
                                        ret |= eth_env_set_enetaddr_by_index("eth",
                                                        macid++, desc->mac_addr[i]);