]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: Fix error handling in sb_eth_raw_ofdata_to_platdata()
authorSimon Glass <sjg@chromium.org>
Mon, 7 Jan 2019 23:44:22 +0000 (16:44 -0700)
committerSimon Glass <sjg@chromium.org>
Tue, 15 Jan 2019 00:47:13 +0000 (17:47 -0700)
At present this stores the error number in an unsigned int so an error is
never detected. Use the existing signed variable instead.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
drivers/net/sandbox-raw.c

index 09cc678ebde72657c3f6e51b631c8dcad2b8bd57..7e6625d0202fcf074a1706705d4e4c0a2915af59 100644 (file)
@@ -152,7 +152,6 @@ static int sb_eth_raw_ofdata_to_platdata(struct udevice *dev)
        struct eth_pdata *pdata = dev_get_platdata(dev);
        struct eth_sandbox_raw_priv *priv = dev_get_priv(dev);
        const char *ifname;
-       u32 local;
        int ret;
 
        pdata->iobase = dev_read_addr(dev);
@@ -173,10 +172,10 @@ static int sb_eth_raw_ofdata_to_platdata(struct udevice *dev)
                       priv->host_ifindex, priv->host_ifname);
        }
 
-       local = sandbox_eth_raw_os_is_local(priv->host_ifname);
-       if (local < 0)
-               return local;
-       priv->local = local;
+       ret = sandbox_eth_raw_os_is_local(priv->host_ifname);
+       if (ret < 0)
+               return ret;
+       priv->local = ret;
 
        return 0;
 }