tools: kwboot: Fix quitting terminal

Sometimes kwboot after quitting terminal prints error message:

  terminal: Bad address

This is caused by trying to call write() syscall with count of (size_t)-1
bytes.

When quit sequence is split into more read() calls then number of input
bytes (nin) at the end of cycle can underflow and be negative. Fix it.

Fixes: de7514046ea5 ("tools: kwboot: Fix detection of quit esc sequence")
Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>

diff --git a/tools/kwboot.c b/tools/kwboot.c
index 68c0ef1f1b07e1303ed2cf164367eae0b9aa78ea..2d2d545d82587d6af0cfb4517405e7157284f9dd 100644 (file)
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -1197,7 +1197,7 @@ kwboot_term_pipe(int in, int out, const char *quit, int *s)
                        if (buf[i] == quit[*s]) {
                                (*s)++;
                                if (!quit[*s]) {
-                                       nin = i - *s;
+                                       nin = (i > *s) ? (i - *s) : 0;
                                        break;
                                }
                        } else {
@@ -1208,7 +1208,7 @@ kwboot_term_pipe(int in, int out, const char *quit, int *s)
                }
 
                if (i == nin)
-                       nin -= *s;
+                       nin -= (nin > *s) ? *s : nin;
        }
 
        if (kwboot_write(out, buf, nin) < 0)