firmware: smci: possible NULL dereference

sandbox_scmi_devices_ctx() may return NULL. We should not dereference this
value in sandbox_scmi_devices_remove().

The problem was indicated by 'gcc-11 -fanalyzer'.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/drivers/firmware/scmi/sandbox-scmi_devices.c b/drivers/firmware/scmi/sandbox-scmi_devices.c
index 414da6f4df1611d73b16797aac058450653f0ded..1a6fafbf531bb843088b76f3c1315b029dd13f82 100644 (file)
--- a/drivers/firmware/scmi/sandbox-scmi_devices.c
+++ b/drivers/firmware/scmi/sandbox-scmi_devices.c
@@ -50,6 +50,9 @@ static int sandbox_scmi_devices_remove(struct udevice *dev)
        int ret = 0;
        size_t n;
 
+       if (!devices)
+               return 0;
+
        for (n = 0; n < SCMI_TEST_DEVICES_RD_COUNT; n++) {
                int ret2 = reset_free(devices->reset + n);