]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mtd: pxa3xx_nand: remove dead code
authorBaruch Siach <baruch@tkos.co.il>
Thu, 29 Oct 2020 06:52:19 +0000 (08:52 +0200)
committerStefan Roese <sr@denx.de>
Thu, 29 Oct 2020 07:00:12 +0000 (08:00 +0100)
The kfree() call is unreachable, and is not needed. Remove this call and
the fail_disable_clk label.

Reviewed-by: Stefan Roese <sr@denx.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
drivers/mtd/nand/raw/pxa3xx_nand.c

index c9b7a4251b4e1a28705963336e66522aeb29748e..8481c6e3bf917251fc68adc4fe4bdd50b0e898fa 100644 (file)
@@ -1768,7 +1768,7 @@ static int alloc_nand_resource(struct pxa3xx_nand_info *info)
        struct pxa3xx_nand_host *host;
        struct nand_chip *chip = NULL;
        struct mtd_info *mtd;
-       int ret, cs;
+       int cs;
 
        pdata = info->pdata;
        if (pdata->num_cs <= 0)
@@ -1804,19 +1804,13 @@ static int alloc_nand_resource(struct pxa3xx_nand_info *info)
        /* Allocate a buffer to allow flash detection */
        info->buf_size = INIT_BUFFER_SIZE;
        info->data_buff = kmalloc(info->buf_size, GFP_KERNEL);
-       if (info->data_buff == NULL) {
-               ret = -ENOMEM;
-               goto fail_disable_clk;
-       }
+       if (info->data_buff == NULL)
+               return -ENOMEM;
 
        /* initialize all interrupts to be disabled */
        disable_int(info, NDSR_MASK);
 
        return 0;
-
-       kfree(info->data_buff);
-fail_disable_clk:
-       return ret;
 }
 
 static int pxa3xx_nand_probe_dt(struct udevice *dev, struct pxa3xx_nand_info *info)