checkpatch.pl: Add warning for new __packed additions

While there are valid reasons to use __packed, often the answer is that
you should be doing something else here instead.

This reintroduces the changes of
f503cc49a570 (Add warning for new __packed additions)

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2287a0bca863bf57ffabaae9de58aab0174826c3..4142f5c837e21bd912b0770e68cc427c308dec16 100755 (executable)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5616,6 +5616,13 @@ sub process {
                             "__packed is preferred over __attribute__((packed))\n" . $herecurr);
                }
 
+# Check for new packed members, warn to use care
+               if ($realfile !~ m@\binclude/uapi/@ &&
+                   $line =~ /\b(__attribute__\s*\(\s*\(.*\bpacked|__packed)\b/) {
+                       WARN("NEW_PACKED",
+                            "Adding new packed members is to be done with care\n" . $herecurr);
+               }
+
 # Check for __attribute__ aligned, prefer __aligned
                if ($realfile !~ m@\binclude/uapi/@ &&
                    $line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {