]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mtd: nand: zynq_nand: Change datatype of status and ecc_status to int
authorAlgapally Santosh Sagar <santoshsagar.algapally@amd.com>
Wed, 14 Jun 2023 09:03:57 +0000 (03:03 -0600)
committerMichal Simek <michal.simek@amd.com>
Fri, 21 Jul 2023 07:00:38 +0000 (09:00 +0200)
status and ecc_status are of unsigned type where they are compared for
negative value. This is pointed by below sparse warning. Change datatype
to int to fix this.
warning: comparison of unsigned expression in '< 0' is always false
[-Wtype-limits]

Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
Link: https://lore.kernel.org/r/20230614090359.10809-5-ashok.reddy.soma@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/mtd/nand/raw/zynq_nand.c

index 9e3ee7412d006dd0c202f7f651114aa5e8c59d07..545fdd7b69737d3d75189aee9a6b6c39acf26643 100644 (file)
@@ -285,7 +285,7 @@ static int zynq_nand_init_nand_flash(struct mtd_info *mtd, int option)
 {
        struct nand_chip *nand_chip = mtd_to_nand(mtd);
        struct nand_drv *smc = nand_get_controller_data(nand_chip);
-       u32 status;
+       int status;
 
        /* disable interrupts */
        writel(ZYNQ_NAND_CLR_CONFIG, &smc->reg->cfr);
@@ -332,7 +332,7 @@ static int zynq_nand_calculate_hwecc(struct mtd_info *mtd, const u8 *data,
        struct nand_drv *smc = nand_get_controller_data(nand_chip);
        u32 ecc_value = 0;
        u8 ecc_reg, ecc_byte;
-       u32 ecc_status;
+       int ecc_status;
 
        /* Wait till the ECC operation is complete */
        ecc_status = zynq_nand_waitfor_ecc_completion(mtd);