]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
gpio: zynqmp: Handle error from get_gpio_modepin
authorAlgapally Santosh Sagar <santoshsagar.algapally@amd.com>
Fri, 20 Jan 2023 05:36:15 +0000 (22:36 -0700)
committerMichal Simek <michal.simek@amd.com>
Fri, 27 Jan 2023 07:42:47 +0000 (08:42 +0100)
There is a unused variable ret, due to which we are getting sparse warning
as below.
warning: variable 'ret' set but not used [-Wunused-but-set-variable].

Return ret incase of error.

Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally@amd.com>
Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
Link: https://lore.kernel.org/r/20230120053617.32463-3-ashok.reddy.soma@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>
drivers/gpio/zynqmp_gpio_modepin.c

index 078fd833959a09cd30d21df3ad503460d8dee910..e9565ff5430e04720748bc2d5ef63d4ef98636a4 100644 (file)
@@ -48,6 +48,9 @@ static int modepin_gpio_set_value(struct udevice *dev, unsigned int offset,
        int ret;
 
        ret = get_gpio_modepin(ret_payload);
+       if (ret)
+               return ret;
+
        if (value)
                out_val = OUTVAL(offset) | ret_payload[1];
        else