]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
gadget: f_thor: add missing line breaks for pr_err()
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Thu, 13 Feb 2020 08:24:11 +0000 (17:24 +0900)
committerMarek Vasut <marek.vasut+renesas@gmail.com>
Sun, 1 Mar 2020 20:58:54 +0000 (21:58 +0100)
After the commit 9b643e312d52 ("treewide: replace with error()
with pr_err()"), there are pr_err() usages without line break. Add
missing line breaks for pr_err() used in f_thor.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
drivers/usb/gadget/f_thor.c

index 5a023a2b34c1afa854805d2d2cb7f5ed37d9d105..ee646fdd5ce721db7799da7d37f916904c69ff6e 100644 (file)
@@ -174,7 +174,7 @@ static long long int download_head(unsigned long long total,
                                        transfer_buffer, THOR_STORE_UNIT_SIZE,
                                        (*cnt)++);
                        if (ret) {
-                               pr_err("DFU write failed [%d] cnt: %d",
+                               pr_err("DFU write failed [%d] cnt: %d\n",
                                      ret, *cnt);
                                return ret;
                        }
@@ -224,14 +224,14 @@ static int download_tail(long long int left, int cnt)
 
        transfer_buffer = dfu_get_buf(dfu_entity);
        if (!transfer_buffer) {
-               pr_err("Transfer buffer not allocated!");
+               pr_err("Transfer buffer not allocated!\n");
                return -ENXIO;
        }
 
        if (left) {
                ret = dfu_write(dfu_entity, transfer_buffer, left, cnt++);
                if (ret) {
-                       pr_err("DFU write failed [%d]: left: %llu", ret, left);
+                       pr_err("DFU write failed[%d]: left: %llu\n", ret, left);
                        return ret;
                }
        }
@@ -245,7 +245,7 @@ static int download_tail(long long int left, int cnt)
         */
        ret = dfu_flush(dfu_entity, transfer_buffer, 0, cnt);
        if (ret)
-               pr_err("DFU flush failed!");
+               pr_err("DFU flush failed!\n");
 
        return ret;
 }
@@ -290,7 +290,7 @@ static long long int process_rqt_download(const struct rqt_box *rqt)
 
                alt_setting_num = dfu_get_alt(f_name);
                if (alt_setting_num < 0) {
-                       pr_err("Alt setting [%d] to write not found!",
+                       pr_err("Alt setting [%d] to write not found!\n",
                              alt_setting_num);
                        rsp->ack = -ENODEV;
                        ret = rsp->ack;
@@ -316,7 +316,7 @@ static long long int process_rqt_download(const struct rqt_box *rqt)
                debug("DL EXIT\n");
                break;
        default:
-               pr_err("Operation not supported: %d", rqt->rqt_data);
+               pr_err("Operation not supported: %d\n", rqt->rqt_data);
                ret = -ENOTSUPP;
        }
 
@@ -347,7 +347,7 @@ static int process_data(void)
                puts("RQT: UPLOAD not supported!\n");
                break;
        default:
-               pr_err("unknown request (%d)", rqt->rqt);
+               pr_err("unknown request (%d)\n", rqt->rqt);
        }
 
        return ret;
@@ -546,7 +546,7 @@ static int thor_rx_data(void)
 
                status = usb_ep_queue(dev->out_ep, dev->out_req, 0);
                if (status) {
-                       pr_err("kill %s:  resubmit %d bytes --> %d",
+                       pr_err("kill %s:  resubmit %d bytes --> %d\n",
                              dev->out_ep->name, dev->out_req->length, status);
                        usb_ep_set_halt(dev->out_ep);
                        return -EAGAIN;
@@ -580,7 +580,7 @@ static void thor_tx_data(unsigned char *data, int len)
 
        status = usb_ep_queue(dev->in_ep, dev->in_req, 0);
        if (status) {
-               pr_err("kill %s:  resubmit %d bytes --> %d",
+               pr_err("kill %s:  resubmit %d bytes --> %d\n",
                      dev->in_ep->name, dev->in_req->length, status);
                usb_ep_set_halt(dev->in_ep);
        }
@@ -613,7 +613,7 @@ static void thor_rx_tx_complete(struct usb_ep *ep, struct usb_request *req)
        case -ESHUTDOWN:                /* disconnect from host */
        case -EREMOTEIO:                /* short read */
        case -EOVERFLOW:
-               pr_err("ERROR:%d", status);
+               pr_err("ERROR:%d\n", status);
                break;
        }
 
@@ -653,7 +653,7 @@ thor_func_setup(struct usb_function *f, const struct usb_ctrlrequest *ctrl)
                break;
 
        default:
-               pr_err("thor_setup: unknown request: %d", ctrl->bRequest);
+               pr_err("thor_setup: unknown request: %d\n", ctrl->bRequest);
        }
 
        if (value >= 0) {
@@ -984,7 +984,7 @@ static int thor_func_set_alt(struct usb_function *f,
                debug("Communication Data interface\n");
                result = thor_eps_setup(f);
                if (result)
-                       pr_err("%s: EPs setup failed!", __func__);
+                       pr_err("%s: EPs setup failed!\n", __func__);
                dev->configuration_done = 1;
                break;
        }