]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
sunxi: remove __packed from struct sunxi_prcm_reg
authorHeinrich Schuchardt <xypron.glpk@gmx.de>
Tue, 17 Dec 2019 21:55:42 +0000 (22:55 +0100)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 18 Dec 2019 14:49:58 +0000 (20:19 +0530)
struct sunxi_prcm_reg is naturally packed. There is no need to define it as
packed. Defining it as packed leads to compilation errors with GCC 9.2.1:

  CC      arch/arm/lib/reloc_arm_efi.o
arch/arm/cpu/armv7/sunxi/psci.c: In function ‘sunxi_cpu_set_power’:
:qarch/arm/cpu/armv7/sunxi/psci.c:163:21: error: taking address of packed
member of ‘struct sunxi_prcm_reg’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
  163 |  sunxi_power_switch(&prcm->cpu_pwr_clamp[cpu], &prcm->cpu_pwroff,
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~

Remove __packed attribute from struct sunxi_prcm_reg.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
arch/arm/include/asm/arch-sunxi/prcm.h

index 58a36895e6de50a3f8951501836bbfc9a8ccfee4..767d1ff98d7469fa0e03f482c3e60a08b11efda0 100644 (file)
 #ifndef __ASSEMBLY__
 #include <linux/compiler.h>
 
-struct __packed sunxi_prcm_reg {
+struct sunxi_prcm_reg {
        u32 cpus_cfg;           /* 0x000 */
        u8 res0[0x8];           /* 0x004 */
        u32 apb0_ratio;         /* 0x00c */