]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
bootm: Reduce arguments to bootm_find_os()
authorSimon Glass <sjg@chromium.org>
Sat, 18 Nov 2023 21:05:05 +0000 (14:05 -0700)
committerTom Rini <trini@konsulko.com>
Wed, 13 Dec 2023 16:51:24 +0000 (11:51 -0500)
This function only uses one argument so pass it in directly.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
boot/bootm.c

index 7aca2bf8146c9e6f06197539df7258052148507b..922989b9cfcfdf998d8e007fdbdb56ac119ae6b8 100644 (file)
@@ -304,8 +304,14 @@ static int bootm_pre_load(const char *addr_str)
        return ret;
 }
 
-static int bootm_find_os(struct cmd_tbl *cmdtp, int flag, int argc,
-                        char *const argv[])
+/**
+ * bootm_find_os(): Find the OS to boot
+ *
+ * @cmd_name: Command name that started this boot, e.g. "bootm"
+ * @addr_fit: Address and/or FIT specifier (first arg of bootm command)
+ * Return: 0 on success, -ve on error
+ */
+static int bootm_find_os(const char *cmd_name, const char *addr_fit)
 {
        const void *os_hdr;
 #ifdef CONFIG_ANDROID_BOOT_IMAGE
@@ -316,12 +322,11 @@ static int bootm_find_os(struct cmd_tbl *cmdtp, int flag, int argc,
        int ret;
 
        /* get kernel image header, start address and length */
-       ret = boot_get_kernel(argv[0], &images, &images.os.image_start,
+       ret = boot_get_kernel(addr_fit, &images, &images.os.image_start,
                              &images.os.image_len, &os_hdr);
        if (ret) {
                if (ret == -EPROTOTYPE)
-                       printf("Wrong Image Type for %s command\n",
-                              cmdtp->name);
+                       printf("Wrong Image Type for %s command\n", cmd_name);
 
                printf("ERROR %dE: can't get kernel image!\n", ret);
                return 1;
@@ -987,7 +992,7 @@ int do_bootm_states(struct cmd_tbl *cmdtp, int flag, int argc,
                ret = bootm_pre_load(argv[0]);
 
        if (!ret && (states & BOOTM_STATE_FINDOS))
-               ret = bootm_find_os(cmdtp, flag, argc, argv);
+               ret = bootm_find_os(cmdtp->name, argv[0]);
 
        if (!ret && (states & BOOTM_STATE_FINDOTHER))
                ret = bootm_find_other(cmdtp, flag, argc, argv);