net: hifemac_mdio: use log_msg_ret() correctly, report error by dev_err()

The initial commit used log_msg_ret() wrongly. Fix that by moving error
report to a separate dev_err() call and shrink the first argument of
log_msg_ret() to no more than 4 chars.

Fixes: 6b5c8d98e204 ("net: add hifemac_mdio MDIO bus driver for HiSilicon platform")
Signed-off-by: Yang Xiwen <forbidden405@outlook.com>

diff --git a/drivers/net/hifemac_mdio.c b/drivers/net/hifemac_mdio.c
index 343c5f3a38a7773037c16747a28a3e39959b0fe1..0b59d0609175fc7464185391acd28a0ebacd3ad0 100644 (file)
--- a/drivers/net/hifemac_mdio.c
+++ b/drivers/net/hifemac_mdio.c
@@ -8,6 +8,7 @@
 #include <dm.h>
 #include <clk.h>
 #include <miiphy.h>
+#include <dm/device_compat.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
 
@@ -74,7 +75,8 @@ static int hisi_femac_mdio_of_to_plat(struct udevice *dev)
        data->membase = dev_remap_addr(dev);
        if (IS_ERR(data->membase)) {
                ret = PTR_ERR(data->membase);
-               return log_msg_ret("Failed to remap base addr", ret);
+               dev_err(dev, "Failed to remap base addr %d\n", ret);
+               return log_msg_ret("mdio", ret);
        }
 
        // clk is optional
@@ -89,8 +91,10 @@ static int hisi_femac_mdio_probe(struct udevice *dev)
        int ret;
 
        ret = clk_prepare_enable(data->clk);
-       if (ret)
-               return log_msg_ret("Failed to enable clk", ret);
+       if (ret) {
+               dev_err(dev, "Failed to enable clock: %d\n", ret);
+               return log_msg_ret("clk", ret);
+       }
 
        return 0;
 }
@@ -112,5 +116,6 @@ U_BOOT_DRIVER(hisi_femac_mdio_driver) = {
        .of_to_plat = hisi_femac_mdio_of_to_plat,
        .probe = hisi_femac_mdio_probe,
        .ops = &hisi_femac_mdio_ops,
+       .plat_auto = sizeof(struct mdio_perdev_priv),
        .priv_auto = sizeof(struct hisi_femac_mdio_data),
 };