]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: phy: fixed: Drop #ifdef CONFIG_DM_ETH around phy_connect_fixed
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sun, 14 Mar 2021 12:14:49 +0000 (20:14 +0800)
committerPriyanka Jain <priyanka.jain@nxp.com>
Thu, 15 Apr 2021 08:52:17 +0000 (14:22 +0530)
In drivers/net/phy/Kconfig, CONFIG_PHY_FIXED already depends on
CONFIG_DM_ETH, so the function prototype definition when
CONFIG_DM_ETH=n does nothing, so it can be dropped. It is also
never reachable, since the whole function is already under #ifdef
CONFIG_PHY_FIXED (which again, as I said, depends on CONFIG_DM_ETH=y).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Message-Id: <20210216224804.3355044-3-olteanv@gmail.com>
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com>
drivers/net/phy/phy.c

index 2feb559bba97687b3833fa1cb7b9b274111f396a..eae40cc0d6b783dde92b2d5691149a4623d59792 100644 (file)
@@ -1012,15 +1012,9 @@ struct phy_device *fixed_phy_create(ofnode node)
        return phydev;
 }
 
-#ifdef CONFIG_DM_ETH
 static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
                                            struct udevice *dev,
                                            phy_interface_t interface)
-#else
-static struct phy_device *phy_connect_fixed(struct mii_dev *bus,
-                                           struct eth_device *dev,
-                                           phy_interface_t interface)
-#endif
 {
        ofnode node = dev_ofnode(dev), subnode;
        struct phy_device *phydev;