]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
ram: rk3328: Use correct frequency units in function
authorSimon South <simon@simonsouth.net>
Sun, 6 Oct 2019 16:28:13 +0000 (12:28 -0400)
committerKever Yang <kever.yang@rock-chips.com>
Sun, 10 Nov 2019 12:40:20 +0000 (20:40 +0800)
Fix a pair of tests in phy_dll_bypass_set() that used incorrect units
for the DDR frequency, causing the DRAM controller to be misconfigured
in most cases.

Signed-off-by: Simon South <simon@simonsouth.net>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/ram/rockchip/sdram_rk3328.c

index 656696ac3c538fdb0f0f25ca9b7d6a179467f9ae..0541bbadf074bae845bf9032bceec800c96a8473 100644 (file)
@@ -311,12 +311,12 @@ static void phy_dll_bypass_set(struct dram_info *dram, u32 freq)
        setbits_le32(PHY_REG(phy_base, 0x56), 1 << 4);
        clrbits_le32(PHY_REG(phy_base, 0x57), 1 << 3);
 
-       if (freq <= (400 * MHz))
+       if (freq <= 400)
                /* DLL bypass */
                setbits_le32(PHY_REG(phy_base, 0xa4), 0x1f);
        else
                clrbits_le32(PHY_REG(phy_base, 0xa4), 0x1f);
-       if (freq <= (680 * MHz))
+       if (freq <= 680)
                tmp = 2;
        else
                tmp = 1;