eth/r8152: free previous memory if r8152_eth_probe fail

The r8152_eth_probe() may allocate a memory for ss->dev_priv.
It has to be freed if r8152_eth_probe() fails finally.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>

diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c
index 215bcbbef80419a0c92b1ff828b68147d897f742..82a05a9c3515e1423795b53a7d5e6dcd90930f3d 100644 (file)
--- a/drivers/usb/eth/r8152.c
+++ b/drivers/usb/eth/r8152.c
@@ -1647,7 +1647,7 @@ int r8152_eth_probe(struct usb_device *dev, unsigned int ifnum,
        if (usb_set_interface(dev, iface_desc->bInterfaceNumber, 0) ||
            !ss->ep_in || !ss->ep_out || !ss->ep_int) {
                debug("Problems with device\n");
-               return 0;
+               goto error;
        }
 
        dev->privptr = (void *)ss;
@@ -1659,7 +1659,7 @@ int r8152_eth_probe(struct usb_device *dev, unsigned int ifnum,
        r8152b_get_version(tp);
 
        if (rtl_ops_init(tp))
-               return 0;
+               goto error;
 
        tp->rtl_ops.init(tp);
        tp->rtl_ops.up(tp);
@@ -1669,6 +1669,11 @@ int r8152_eth_probe(struct usb_device *dev, unsigned int ifnum,
                          DUPLEX_FULL);
 
        return 1;
+
+error:
+       cfree(ss->dev_priv);
+       ss->dev_priv = 0;
+       return 0;
 }
 
 int r8152_eth_get_info(struct usb_device *dev, struct ueth_data *ss,