]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
checkpatch.pl: Make fdt / initrd relocation disabling an error
authorTom Rini <trini@konsulko.com>
Thu, 20 Aug 2020 12:37:49 +0000 (08:37 -0400)
committerTom Rini <trini@konsulko.com>
Thu, 27 Aug 2020 15:26:58 +0000 (11:26 -0400)
Entirely disabling relocation of the device tree or initrd is almost
never the right answer.  Doing this by default leads to hard to diagnose
run-time failures.

Signed-off-by: Tom Rini <trini@konsulko.com>
scripts/checkpatch.pl

index 3932362dbafd555a6850b74b776ccf83e1189b83..4bed2b0cdc7c2a59c7b620e89cd602933e8685b1 100755 (executable)
@@ -2359,6 +2359,12 @@ sub u_boot_line {
                ERROR("BARRED_INCLUDE_IN_HDR",
                      "Avoid including common.h and dm.h in header files\n" . $herecurr);
        }
+
+       # Do not disable fdt / initrd relocation
+       if ($rawline =~ /.*(fdt|initrd)_high=0xffffffff/) {
+               ERROR("DISABLE_FDT_OR_INITRD_RELOC",
+                    "fdt or initrd relocation disabled at boot time\n" . $herecurr);
+       }
 }
 
 sub process {