net: phy: dp83867: avoid error in dp83867_of_init() when PHY has no OF node

A DM_ETH driver may use phy_connect() towards a PHY address on an MDIO
bus which is not specified in the device tree, as evidenced by:

pfe_eth_probe
-> pfe_phy_configure
   -> phy_connect

When this happens, the PHY will have an invalid OF node.

The dp83867_config() method has extra initialization steps which are
bypassed when the PHY lacks an OF node, which is undesirable because it
will lead to broken networking. Allow the rest of the code to run.

Fixes: 085445ca4104 ("net: phy: ti: Allow the driver to be more configurable")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index eada4541c9c336c786ec2d0c7d5bfe5e77edaa23..49978d0f25f3948dddf915d3f1a0927c4ed72537 100644 (file)
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -158,7 +158,7 @@ static int dp83867_of_init(struct phy_device *phydev)
 
        node = phy_get_ofnode(phydev);
        if (!ofnode_valid(node))
-               return -EINVAL;
+               return 0;
 
        /* Optional configuration */
        ret = ofnode_read_u32(node, "ti,clk-output-sel",