]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: sun8i_emac: Fix overlong lines
authorAndre Przywara <andre.przywara@arm.com>
Mon, 6 Jul 2020 00:40:41 +0000 (01:40 +0100)
committerJagan Teki <jagan@amarulasolutions.com>
Wed, 21 Oct 2020 18:14:40 +0000 (23:44 +0530)
When iterating over all RX/TX buffers, we were using a rather long "idx"
control variable, which lead to a nasty overlong line.

Replace "idx" with "i" to avoid this.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Tested-by: Amit Singh Tomar <amittomer25@gmail.com> # Pine64+
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
drivers/net/sun8i_emac.c

index c005b98ae83b343035d749f0f5aa234bfc1905c2..1ae5bfd38832d3e1c55d21d7853a67a10769bca5 100644 (file)
@@ -389,7 +389,7 @@ static void rx_descs_init(struct emac_eth_dev *priv)
        struct emac_dma_desc *desc_table_p = &priv->rx_chain[0];
        char *rxbuffs = &priv->rxbuffer[0];
        struct emac_dma_desc *desc_p;
-       u32 idx;
+       int i;
 
        /*
         * Make sure we don't have dirty cache lines around, which could
@@ -400,11 +400,10 @@ static void rx_descs_init(struct emac_eth_dev *priv)
        invalidate_dcache_range((uintptr_t)rxbuffs,
                                (uintptr_t)rxbuffs + sizeof(priv->rxbuffer));
 
-       for (idx = 0; idx < CONFIG_RX_DESCR_NUM; idx++) {
-               desc_p = &desc_table_p[idx];
-               desc_p->buf_addr = (uintptr_t)&rxbuffs[idx * CONFIG_ETH_BUFSIZE]
-                       ;
-               desc_p->next = (uintptr_t)&desc_table_p[idx + 1];
+       for (i = 0; i < CONFIG_RX_DESCR_NUM; i++) {
+               desc_p = &desc_table_p[i];
+               desc_p->buf_addr = (uintptr_t)&rxbuffs[i * CONFIG_ETH_BUFSIZE];
+               desc_p->next = (uintptr_t)&desc_table_p[i + 1];
                desc_p->ctl_size = CONFIG_ETH_RXSIZE;
                desc_p->status = EMAC_DESC_OWN_DMA;
        }
@@ -425,13 +424,12 @@ static void tx_descs_init(struct emac_eth_dev *priv)
        struct emac_dma_desc *desc_table_p = &priv->tx_chain[0];
        char *txbuffs = &priv->txbuffer[0];
        struct emac_dma_desc *desc_p;
-       u32 idx;
+       int i;
 
-       for (idx = 0; idx < CONFIG_TX_DESCR_NUM; idx++) {
-               desc_p = &desc_table_p[idx];
-               desc_p->buf_addr = (uintptr_t)&txbuffs[idx * CONFIG_ETH_BUFSIZE]
-                       ;
-               desc_p->next = (uintptr_t)&desc_table_p[idx + 1];
+       for (i = 0; i < CONFIG_TX_DESCR_NUM; i++) {
+               desc_p = &desc_table_p[i];
+               desc_p->buf_addr = (uintptr_t)&txbuffs[i * CONFIG_ETH_BUFSIZE];
+               desc_p->next = (uintptr_t)&desc_table_p[i + 1];
                desc_p->ctl_size = 0;
                desc_p->status = 0;
        }