rockchip: pinctrl: rk3328: do not set io routing

In rk3328, some function pin may have more than one choice, and muxed
with more than one IO, for example, the UART2 controller IO,
TX and RX, have 3 choice(setting in com_iomux):
- M0 which mux with GPIO1A0/GPIO1A1
- M1 which mux with GPIO2A0/GPIO2A1
- usb2phy which mux with USB2.0 DP/DM pin.

We should not decide which group to use in pinctrl driver,
for it may be different in different board, it should goes to board
file, and the pinctrl file should setting correct iomux depends on
the com_iomux value.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Acked-by: Simon Glass <sjg@chromium.org>

diff --git a/arch/arm/include/asm/arch-rockchip/grf_rk3328.h b/arch/arm/include/asm/arch-rockchip/grf_rk3328.h
index 40a4de0db60e3741fddbbc344ba873b97f4b677e..f0a0781d8db376a9c243d6dfe14d54d4d833267b 100644 (file)
--- a/arch/arm/include/asm/arch-rockchip/grf_rk3328.h
+++ b/arch/arm/include/asm/arch-rockchip/grf_rk3328.h
@@ -228,21 +228,21 @@ enum {
        GPIO3C0_EMMC_DATA567_PWR_CLK_RSTN_CMD   = 0x2aaa,
 
        /* COM_IOMUX */
-       UART2_IOMUX_SEL_SHIFT   = 0,
-       UART2_IOMUX_SEL_MASK    = 3 << UART2_IOMUX_SEL_SHIFT,
-       UART2_IOMUX_SEL_M0              = 0,
-       UART2_IOMUX_SEL_M1,
-
-       SPI_IOMUX_SEL_SHIFT = 4,
-       SPI_IOMUX_SEL_MASK      = 3 << SPI_IOMUX_SEL_SHIFT,
-       SPI_IOMUX_SEL_M0        = 0,
-       SPI_IOMUX_SEL_M1,
-       SPI_IOMUX_SEL_M2,
-
-       CARD_IOMUX_SEL_SHIFT    = 7,
-       CARD_IOMUX_SEL_MASK             = 1 << CARD_IOMUX_SEL_SHIFT,
-       CARD_IOMUX_SEL_M0               = 0,
-       CARD_IOMUX_SEL_M1,
+       IOMUX_SEL_UART2_SHIFT   = 0,
+       IOMUX_SEL_UART2_MASK    = 3 << IOMUX_SEL_UART2_SHIFT,
+       IOMUX_SEL_UART2_M0      = 0,
+       IOMUX_SEL_UART2_M1,
+
+       IOMUX_SEL_SPI_SHIFT     = 4,
+       IOMUX_SEL_SPI_MASK      = 3 << IOMUX_SEL_SPI_SHIFT,
+       IOMUX_SEL_SPI_M0        = 0,
+       IOMUX_SEL_SPI_M1,
+       IOMUX_SEL_SPI_M2,
+
+       IOMUX_SEL_SDMMC_SHIFT   = 7,
+       IOMUX_SEL_SDMMC_MASK    = 1 << IOMUX_SEL_SDMMC_SHIFT,
+       IOMUX_SEL_SDMMC_M0      = 0,
+       IOMUX_SEL_SDMMC_M1,
 };
 
 #endif /* __SOC_ROCKCHIP_RK3328_GRF_H__ */

diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3328.c b/drivers/pinctrl/rockchip/pinctrl_rk3328.c
index cf3435e37fea572a4cd259f06836fc93b951a422..d0ffeb1f0447d68c999fa2217e33b860894a1809 100644 (file)
--- a/drivers/pinctrl/rockchip/pinctrl_rk3328.c
+++ b/drivers/pinctrl/rockchip/pinctrl_rk3328.c
@@ -97,9 +97,13 @@ static void pinctrl_rk3328_lcdc_config(struct rk3328_grf_regs *grf, int lcd_id)
 static int pinctrl_rk3328_spi_config(struct rk3328_grf_regs *grf,
                                     enum periph_id spi_id, int cs)
 {
-       rk_clrsetreg(&grf->com_iomux,
-                    SPI_IOMUX_SEL_MASK,
-                    SPI_IOMUX_SEL_M0 << SPI_IOMUX_SEL_SHIFT);
+       u32 com_iomux = readl(&grf->com_iomux);
+
+       if ((com_iomux & IOMUX_SEL_SPI_MASK) !=
+               IOMUX_SEL_SPI_M0 << IOMUX_SEL_SPI_SHIFT) {
+               debug("driver do not support iomux other than m0\n");
+               goto err;
+       }
 
        switch (spi_id) {
        case PERIPH_ID_SPI0:
@@ -135,18 +139,17 @@ err:
 
 static void pinctrl_rk3328_uart_config(struct rk3328_grf_regs *grf, int uart_id)
 {
+       u32 com_iomux = readl(&grf->com_iomux);
+
        switch (uart_id) {
        case PERIPH_ID_UART2:
                break;
-               /* uart2 iomux select m1 */
-               rk_clrsetreg(&grf->com_iomux,
-                            UART2_IOMUX_SEL_MASK,
-                            UART2_IOMUX_SEL_M1
-                            << UART2_IOMUX_SEL_SHIFT);
-               rk_clrsetreg(&grf->gpio2a_iomux,
-                            GPIO2A0_SEL_MASK | GPIO2A1_SEL_MASK,
-                            GPIO2A0_UART2_TX_M1 << GPIO2A0_SEL_SHIFT |
-                            GPIO2A1_UART2_RX_M1 << GPIO2A1_SEL_SHIFT);
+               if (com_iomux & IOMUX_SEL_UART2_MASK)
+                       rk_clrsetreg(&grf->gpio2a_iomux,
+                                    GPIO2A0_SEL_MASK | GPIO2A1_SEL_MASK,
+                                    GPIO2A0_UART2_TX_M1 << GPIO2A0_SEL_SHIFT |
+                                    GPIO2A1_UART2_RX_M1 << GPIO2A1_SEL_SHIFT);
+
                break;
        case PERIPH_ID_UART0:
        case PERIPH_ID_UART1:
@@ -161,6 +164,8 @@ static void pinctrl_rk3328_uart_config(struct rk3328_grf_regs *grf, int uart_id)
 static void pinctrl_rk3328_sdmmc_config(struct rk3328_grf_regs *grf,
                                        int mmc_id)
 {
+       u32 com_iomux = readl(&grf->com_iomux);
+
        switch (mmc_id) {
        case PERIPH_ID_EMMC:
                rk_clrsetreg(&grf->gpio0a_iomux,
@@ -175,13 +180,17 @@ static void pinctrl_rk3328_sdmmc_config(struct rk3328_grf_regs *grf,
                             << GPIO3C0_SEL_SHIFT);
                break;
        case PERIPH_ID_SDCARD:
-               /* sdcard iomux select m0 */
-               rk_clrsetreg(&grf->com_iomux,
-                            CARD_IOMUX_SEL_MASK,
-                            CARD_IOMUX_SEL_M0 << CARD_IOMUX_SEL_SHIFT);
-               rk_clrsetreg(&grf->gpio2a_iomux,
-                            GPIO2A7_SEL_MASK,
-                            GPIO2A7_SDMMC0_PWRENM0 << GPIO2A7_SEL_SHIFT);
+               /* SDMMC_PWREN use GPIO and init as regulator-fiexed  */
+               if (com_iomux & IOMUX_SEL_SDMMC_MASK)
+                       rk_clrsetreg(&grf->gpio0d_iomux,
+                                    GPIO0D6_SEL_MASK,
+                                    GPIO0D6_SDMMC0_PWRENM1
+                                    << GPIO0D6_SEL_SHIFT);
+               else
+                       rk_clrsetreg(&grf->gpio2a_iomux,
+                                    GPIO2A7_SEL_MASK,
+                                    GPIO2A7_SDMMC0_PWRENM0
+                                    << GPIO2A7_SEL_SHIFT);
                rk_clrsetreg(&grf->gpio1a_iomux,
                             GPIO1A0_SEL_MASK,
                             GPIO1A0_CARD_DATA_CLK_CMD_DETN