gpio: sandbox: Fully separate pin value from output value

At present we have the concept of a pin's external value. This is what
is used when getting the value of a pin. But we still set the
GPIOD_IS_OUT_ACTIVE flag when changing the value. This is not actually
correct, since if the pin changes from output to input, the external
value need not change. Adjust the logic for this difference.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

diff --git a/drivers/gpio/sandbox.c b/drivers/gpio/sandbox.c
index 4d73b954b26e89ed12f07eecdfc0f45064676874..912c333e560c1b85719db0d051e3280c1b588707 100644 (file)
--- a/drivers/gpio/sandbox.c
+++ b/drivers/gpio/sandbox.c
@@ -85,7 +85,7 @@ int sandbox_gpio_get_value(struct udevice *dev, unsigned offset)
 
 int sandbox_gpio_set_value(struct udevice *dev, unsigned offset, int value)
 {
-       set_gpio_flag(dev, offset, GPIOD_IS_OUT_ACTIVE | GPIOD_EXT_HIGH, value);
+       set_gpio_flag(dev, offset, GPIOD_EXT_HIGH, value);
 
        return 0;
 }
@@ -141,10 +141,19 @@ static int sb_gpio_direction_input(struct udevice *dev, unsigned offset)
 static int sb_gpio_direction_output(struct udevice *dev, unsigned offset,
                                    int value)
 {
+       int ret;
+
        debug("%s: offset:%u, value = %d\n", __func__, offset, value);
 
-       return sandbox_gpio_set_direction(dev, offset, 1) |
-               sandbox_gpio_set_value(dev, offset, value);
+       ret = sandbox_gpio_set_direction(dev, offset, 1);
+       if (ret)
+               return ret;
+       ret = set_gpio_flag(dev, offset, GPIOD_IS_OUT_ACTIVE | GPIOD_EXT_HIGH,
+                           value);
+       if (ret)
+               return ret;
+
+       return 0;
 }
 
 /* read GPIO IN value of port 'offset' */
@@ -158,6 +167,8 @@ static int sb_gpio_get_value(struct udevice *dev, unsigned offset)
 /* write GPIO OUT value to port 'offset' */
 static int sb_gpio_set_value(struct udevice *dev, unsigned offset, int value)
 {
+       int ret;
+
        debug("%s: offset:%u, value = %d\n", __func__, offset, value);
 
        if (!sandbox_gpio_get_direction(dev, offset)) {
@@ -166,7 +177,12 @@ static int sb_gpio_set_value(struct udevice *dev, unsigned offset, int value)
                return -1;
        }
 
-       return sandbox_gpio_set_value(dev, offset, value);
+       ret = set_gpio_flag(dev, offset, GPIOD_IS_OUT_ACTIVE | GPIOD_EXT_HIGH,
+                           value);
+       if (ret)
+               return ret;
+
+       return 0;
 }
 
 static int sb_gpio_get_function(struct udevice *dev, unsigned offset)